Support Numpy structured arrays containing an object #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
Author
|
So it looks like partial read and objects don't mix: |
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 30 30
Lines 10586 10611 +25
=======================================
+ Hits 10580 10605 +25
Misses 6 6
|
Member
Author
|
This amounts to quite a simple change if someone wants to take a look: - if dtype == object:
+ if dtype.hasobject: |
6 tasks
Member
Author
|
closing in favor of #813 |
joshmoore
added a commit
to abergou/zarr-python
that referenced
this pull request
Aug 26, 2021
With thanks to @ombschervister
joshmoore
added a commit
that referenced
this pull request
Aug 30, 2021
* Fix structured arrays that contain objects #806 * Ensures that the fill value of structured arrays that contain objects is encoded using object_codec. * Add test and fix-up to ensure compatibility * Update docs/release.rst * Fixup unit testss Don't specify protocol: makes unit tests pass in python3.7 N5 doesn't support object codecs * Fixup linting error Explicitly handle an error condition that can only happen if encode_fill_value or decode_fill_value are directly called. * Add encode/decode tests for codecov * Explicitly import Pickle from numcodecs for mypy * Migrate test from #702 With thanks to @ombschervister * Install types-setuptools for CI Co-authored-by: Attila Bergou <[email protected]> Co-authored-by: Josh Moore <[email protected]> Co-authored-by: jmoore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix #418
migrated from #422 since the repo was removed.
TODO: